Fix linting errors #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kke
commented
Sep 12, 2023
•
kke
commented
- pkg/config/get.go:19:15: SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck)
- pkg/docker/info.go:29:3: S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
- pkg/cluster/formatter.go:96:2: SA4005: ineffective assignment to field writer.err (staticcheck)
S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
SA4005: ineffective assignment to field writer.err (staticcheck) (function converted to pointer receiver and usage changed) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (staticcheck) Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.