Fix tests + enable GH test action #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twz123
approved these changes
Sep 13, 2023
twz123
reviewed
Sep 13, 2023
kke
force-pushed
the
enable-tests
branch
3 times, most recently
from
6f5b43c
to
f49cf94
Compare
kke
force-pushed
the
enable-tests
branch
3 times, most recently
from
ca36fd8
to
9457390
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
not quite sure how it worked before? Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
The retry was only happening on ssh_exchange_identification. It seems the error is almost exclusively kex_exchange_identification nowadays. Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Editors may add / remove linefeeds at EOF which makes the tests fail Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
|
There doesn't seem to be any "allow failure" option for workflows, some of the OS tests fail, but it's better to fix them separately as this PR is getting out of hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables CI test workflow and contains several fixes to the test suite and code that did not pass existing tests.
It seems the test suite last ran on travis five years ago, it's unknown if the suite passed after that.
assert.NoError/assert.NotNilcalls with trailing assertions were converted torequire.NoError/NotNilto avoid having to look at a nil panic in case there was an error already.quay.io/footloose/image=>image) images. To run against online images, use full image path explicitly). An exception to this is the test in client_test.go that runs some tests againstquay.io/footloose/centosand should probably be moved to e2e, removed, changed, or something.-imageflag to the e2e suite for running against a single image instead of all images listed in variables.json. This helps running the suites against a GH workflow matrix and developing images.%imageinside the testname.cmd. I don't know how or if the tests worked before that.footloose ssh -voption for verbose ssh output.ssh_exchange_identification. It seems the error almost exclusively iskex_exchange_identificationnowadays. Both are accepted now as triggers to retry.