Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "footloose" with "go run ...." in e2e tests #29

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

kke
Copy link
Contributor

@kke kke commented Sep 15, 2023

Instead of requiring and using footloose in PATH, replaces the footloose commands encountered in e2e .cmd files with go run <project_root>/.. This allows modifying code and running tests without installing a development version into PATH.

@kke kke added the enhancement New feature or request label Sep 15, 2023
@kke kke requested review from twz123 and ncopa September 15, 2023 13:44
Base automatically changed from remove-variables.json to main September 18, 2023 06:36
@kke kke added the area/e2e label Sep 18, 2023
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke marked this pull request as draft September 18, 2023 09:11
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke marked this pull request as ready for review September 18, 2023 10:56
@kke kke merged commit a754c64 into main Sep 18, 2023
12 checks passed
@kke kke deleted the use-go-run-for-e2e branch September 18, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/e2e enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant