Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that each machine gets a unique machine-id #37

Merged
merged 6 commits into from
Sep 22, 2023
Merged

Ensure that each machine gets a unique machine-id #37

merged 6 commits into from
Sep 22, 2023

Conversation

kke
Copy link
Contributor

@kke kke commented Sep 20, 2023 •
edited

  • Adds a test for checking if the machines get unique machine ids. K8s and some others do not like it when nodes have non-unique machine ids.
  • Fixes the images where this was broken

@kke kke added enhancement New feature or request area/machines area/e2e labels Sep 20, 2023
@kke kke changed the base branch from e2e-assertions-and-captures to main September 20, 2023 12:43
@kke kke force-pushed the test-uniq-machine-id branch 3 times, most recently from 8edc139 to aebeaeb Compare September 21, 2023 12:27
@kke kke changed the title Test that each machine gets an unique machine-id Ensure that each machine gets an unique machine-id Sep 21, 2023
@kke kke force-pushed the test-uniq-machine-id branch 4 times, most recently from 575d1e0 to 21f053d Compare September 21, 2023 12:59
@kke
Add test for unique machine-id
f920200 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke
Fix alpine machine-id
8251729 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke
Fix amazonlinux machine-ids
6fcf4ed 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke
Fix clearlinux machine-id
1eaf0f3 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke
Fix fedora machine-id
87f3d66 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke marked this pull request as ready for review September 21, 2023 13:08
@kke kke changed the title Ensure that each machine gets an unique machine-id Ensure that each machine gets a unique machine-id Sep 21, 2023
@kke
Add missing vim to amazonlinux2023
5ae18e9 
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke merged commit 7723b13 into main Sep 22, 2023
11 checks passed
@kke kke deleted the test-uniq-machine-id branch September 22, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

Assignees
No one assigned
Labels
area/e2e area/machines enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kke @jnummelin