Rename container labels to io.k0sproject.footloose #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, do we need to worry about backwards compatibility (for our internal purposes even)? |
|
To me looks like the labels are added when creating machines and only ever again used in footloose's own test suite. Of course if someone is using those labels for matching containers for some other purpose, their scripts will fail to find them anymore. |
kke
commented
Sep 7, 2023
kke
commented
Sep 7, 2023
kke
commented
Sep 7, 2023
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
twz123
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the labels as suggested in https://docs.docker.com/config/labels-custom-metadata/#key-format-recommendations