Remove ignite backend support #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
force-pushed
the
drop-ignite-backend
branch
from
00e3575
to
185dbc1
Compare
kke
force-pushed
the
drop-ignite-backend
branch
2 times, most recently
from
e6c2e0b
to
373929c
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
drop-ignite-backend
branch
from
373929c
to
0a567a1
Compare
|
There's https://github.com/save-abandoned-projects/ignite so maybe there's a future for ignite 🤔 |
jnummelin
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since weaveworks/ignite is read-only, the support for using it as the backend can probably be removed.
There's no real abstraction for backends, it's all "if m.IsIgnite() { do something else & return }`.