Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which containerd shim we really need #10

Closed
jnummelin opened this issue Jun 25, 2020 · 2 comments
Closed

Which containerd shim we really need #10

jnummelin opened this issue Jun 25, 2020 · 2 comments

Comments

@jnummelin
Copy link
Collaborator

Currently we have 3 shim bins embedded, we only will need probably one.
@ncopa
Copy link
Collaborator

ncopa commented Jun 25, 2020

Maybe we just pick whatever is containerd's default initially and add the others if/when they are needed.

@ncopa
Copy link
Collaborator

ncopa commented Jun 25, 2020

Looks likedefault is containerd-shim:

$ containerd config dump | grep shim
  "io.containerd.timeout.shim.cleanup" = "5s"
  "io.containerd.timeout.shim.load" = "5s"
  "io.containerd.timeout.shim.shutdown" = "3s"
    shim = "containerd-shim"
    no_shim = false
    shim_debug = false

ncopa referenced this issue Jun 25, 2020
@ncopa
only extract the containerd binaries we will actually use
aaaa2d5 
ref https://github.com/Mirantis/mke/issues/10

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
ncopa referenced this issue Jun 26, 2020
@ncopa
only extract the containerd binaries we will actually use
5a7a60f 
ref https://github.com/Mirantis/mke/issues/10

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
jnummelin referenced this issue Jun 26, 2020
@ncopa
Makefile optimizations (#14)
7fe2964 
* only extract the containerd binaries we will actually use

ref https://github.com/Mirantis/mke/issues/10

Signed-off-by: Natanael Copa <ncopa@mirantis.com>

* fix mke target in makefile

Fix so that `make mke` only rebuilds if something changed

Signed-off-by: Natanael Copa <ncopa@mirantis.com>

* run curl silently

It makes parallel builds (make -j8) look better.

Signed-off-by: Natanael Copa <ncopa@mirantis.com>

Co-authored-by: Natanael Copa <ncopa@mirantis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ncopa @jnummelin