Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile optimizations #14

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Makefile optimizations #14

merged 3 commits into from
Jun 26, 2020

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Jun 25, 2020

No description provided.

@ncopa ncopa requested a review from jnummelin June 25, 2020 12:53
@jnummelin
Copy link
Member

@ncopa #16 introduced some conflicts for this :(

@ncopa
Copy link
Collaborator Author

ncopa commented Jun 26, 2020

@ncopa #16 introduced some conflicts for this :(

np. I'll rebase it.

Fix so that `make mke` only rebuilds if something changed

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
It makes parallel builds (make -j8) look better.

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Copy link
Member

@jnummelin jnummelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnummelin jnummelin merged commit 7fe2964 into main Jun 26, 2020
@jnummelin jnummelin deleted the makefile-optimizations branch June 26, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants