-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate config apiVersion and kind #1245
Conversation
b7fc1b2
to
362356c
Compare
|
362356c
to
7042560
Compare
looks like actions are stuck? might be rebasing over main will help, we once already had that behavior. |
7042560
to
7eb56a6
Compare
I'm not sure why the config change smoke is failing. Is it building a config that does not have the fields? |
The controller0 logs have ```
|
7eb56a6
to
8cb7a57
Compare
Hmm, in pkg/component/controller/clusterConfig.go there was: resourceType = v1.TypeMeta{APIVersion: "k0s.k0sproject.io/v1beta1", Kind: "clusterconfigs"} I wonder if that was intentional. I also wonder what happens if that changes when upgrading. |
8cb7a57
to
af92780
Compare
The client-gen thing does have some plural override flag but I'm not sure if it should be used. |
497f9aa
to
702b7c6
Compare
Maybe there should be different config kind for the crd without the node level stuff. |
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
702b7c6
to
867141d
Compare
Signed-off-by: Kimmo Lehto klehto@mirantis.com
Fixes #1237
Errors out if configuration header apiVersion and kind fields do not have the expected values
k0s.k0sproject.io/v1beta1
andClusterConfig
.