[Backport release-1.26] Fix racy leader pool test #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestSecondWatcherAcquiresReleasedLease test was racy concerning which of the two pools would acquire the lease first. As a result, the test would either fail due to an unexpected event order, or hang until aborted because the pools wouldn't emit enough events for the event collection loop to terminate. This behavior was apparently only observable on Windows. Fix this by adding appropriate values for AcquireTime, RenewTime and LeaseDurationSeconds to the pre-created lease, so that it properly reflects its acquisition by the first pool. Also remove the namespace and pool creations from the other tests, as they were unnecessary. Inline the last required lease creation into the racy test case. Remove the WithRenewDeadline options from the pools under test, as they didn't have any impact on the test, neither semantically nor in terms of execution times. Reduce the RetryPeriod to 10 milliseconds to provide even more immediate test feedback. Rename some local variables and rephrase some log strings to make them more consistent. Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com> (cherry picked from commit 544307d) (cherry picked from commit b97c0ef)
twz123
changed the title
twz123
added
chore
backport/release-1.25
juanluisvaladas
approved these changes
May 18, 2023
|
Successfully created backport PR #3130 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.26, triggered by a label in #3039.See .