Manifest applying #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jnummelin
changed the title
jakolehm
reviewed
Jul 1, 2020
Closed
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jakolehm
approved these changes
Jul 1, 2020
absolutely. Given that we find something that fulfills the needs or we have time to implement the "stack" concept as a separate lib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the pain is from the fat that cli-utils is not really properly designed to be used as library. The cobra command stuff leaks around like hell.
As discussed on slack, had to "revert" to flat model as dir-per-bundle model had serious destroy issues with cli-utils.
Signed-off-by: Jussi Nummelin jnummelin@mirantis.com
fixes #28