Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress=plain to all docker build commands #3969

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Add progress=plain to all docker build commands #3969

merged 2 commits into from
Feb 21, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jan 24, 2024

Description

This makes build output readable for Docker 24.x, which has a special terminal output that's not a good choice when run as part of an automated build.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 added the chore label Jan 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@twz123
Add progress=plain to all docker build commands
96d4b93 
This makes build output readable for Docker 24.x, which has a special
terminal output that's not a good choice when run as part of an
automated build.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123
Install docker buildx for self-hosted runners
eb82f42 
They are currently not shipping with buildx by default, so try to
install it.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 marked this pull request as ready for review February 20, 2024 20:31
@twz123 twz123 requested a review from a team as a code owner February 20, 2024 20:31
@twz123 twz123 merged commit b32831c into k0sproject:main Feb 21, 2024
75 checks passed
@twz123 twz123 deleted the docker-plain-progress branch February 21, 2024 08:47
@twz123 twz123 mentioned this pull request May 8, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twz123 @jnummelin