Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove "else if true" #3984

Merged
merged 3 commits into from
Feb 1, 2024
Merged

chore: remove "else if true" #3984

merged 3 commits into from
Feb 1, 2024

Conversation

ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Jan 31, 2024 •
edited
Loading

Description

This is a weird one. I found this in the code and I thought it was strange. I don't understand exactly how we end up in this situation and this fix may be wrong due to that. Please let me know what you think.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore (no functional change expected)

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ricardomaraschini ricardomaraschini requested a review from a team as a code owner January 31, 2024 12:59
@ricardomaraschini
chore: remove "else if true"
3d5529e 
this is a weird one. i found this in the code and i thought it was
strange. i don't understand exactly how we end up in this situation
and this fix may be wrong. please let me know what you think.

Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
kke
kke reviewed Jan 31, 2024
View reviewed changes
pkg/helm/helm.go Outdated Show resolved Hide resolved
kke
kke reviewed Jan 31, 2024
View reviewed changes
pkg/helm/helm.go Outdated Show resolved Hide resolved
ricardomaraschini and others added 2 commits January 31, 2024 17:35
@ricardomaraschini @kke
Update pkg/helm/helm.go
1a8ec3a 
Co-authored-by: Kimmo Lehto <kimmo.lehto@gmail.com>
Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
@ricardomaraschini @kke
Update pkg/helm/helm.go
c40d11d 
Co-authored-by: Kimmo Lehto <kimmo.lehto@gmail.com>
Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
@twz123
Copy link
Member

twz123 commented Feb 1, 2024

Funny. That's probably some scatter from previous refactorings. Thanks for killing it with 🔥.

@twz123 twz123 merged commit 0a53dc2 into k0sproject:main Feb 1, 2024
73 checks passed
@ricardomaraschini ricardomaraschini deleted the remove-else-if-true branch May 15, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke kke approved these changes

@twz123 twz123 Awaiting requested review from twz123 twz123 is a code owner automatically assigned from k0sproject/k0s-maintainers

@jnummelin jnummelin Awaiting requested review from jnummelin jnummelin is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ricardomaraschini @twz123 @kke