Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix availableComponents unit test #4080

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix availableComponents unit test #4080

merged 1 commit into from
Feb 20, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Feb 19, 2024

Description

The result of the slice compaction wasn't used. The test wasn't effective before. Discovered by #4078.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123
Fix availableComponents unit test
ed61efd 
The result of the slice compaction wasn't used. The test wasn't
effective before.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added the chore label Feb 19, 2024
@twz123 twz123 requested a review from a team as a code owner February 19, 2024 16:03
@twz123 twz123 requested review from kke and jnummelin February 19, 2024 16:03
@twz123 twz123 added backport/release-1.26 PR that needs to be backported/cherrypicked to release-1.26 branch backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch labels Feb 19, 2024
@twz123 twz123 mentioned this pull request Feb 19, 2024
Merged
16 tasks
@twz123 twz123 merged commit 2ac3452 into k0sproject:main Feb 20, 2024
78 checks passed
@twz123 twz123 deleted the fix-available-components-unit-test branch February 20, 2024 14:41
@k0s-bot
Copy link

k0s-bot commented Feb 20, 2024

Successfully created backport PR for release-1.26:

This was referenced Feb 20, 2024
Merged
Merged
@k0s-bot
Copy link

k0s-bot commented Feb 20, 2024

Successfully created backport PR for release-1.27:

@k0s-bot
Copy link

k0s-bot commented Feb 20, 2024

Successfully created backport PR for release-1.28:

@k0s-bot k0s-bot mentioned this pull request Feb 20, 2024
Merged
@k0s-bot
Copy link

k0s-bot commented Feb 20, 2024

Successfully created backport PR for release-1.29:

@k0s-bot k0s-bot mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
backport/release-1.26 PR that needs to be backported/cherrypicked to release-1.26 branch backport/release-1.27 PR that needs to be backported/cherrypicked to release-1.27 branch backport/release-1.28 PR that needs to be backported/cherrypicked to release-1.28 branch backport/release-1.29 PR that needs to be backported/cherrypicked to the release-1.29 branch chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twz123 @k0s-bot @jnummelin