Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor API port number in kubeconfig admin subcommand #4340

Merged
merged 3 commits into from May 3, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Apr 26, 2024

Description

The subcommand was not properly replacing the internal cluster URL with the external one with a non-default port for the API. Instead of doing a string replacement on the raw kubeconfig, parse it and do a structured replacement of the URL. Adjust the error message when the admin config is missing. Add some comments that give some hints on how the kubeconfig admin subcommand relates to the kubeconfig generation in certificates.go. Add some unit tests.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
The subcommans was not properly replacing the internal cluster URL with
the external one with a non-default port for the API.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
Instead of doing a string replacement on the raw kubeconfig, parse it
and do a structured replacement of the URL. Adjust the error message
when the admin config is missing. Add some comments that give some
hints on how the kubeconfig admin subcommand relates to the kubeconfig
generation in certificates.go.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 added bug Something isn't working area/cli labels Apr 26, 2024
@twz123 twz123 marked this pull request as ready for review April 26, 2024 16:50
@twz123 twz123 requested a review from a team as a code owner April 26, 2024 16:50
@twz123 twz123 merged commit 252b174 into k0sproject:main May 3, 2024
77 checks passed
@twz123 twz123 deleted the admin-kubeconf-gen branch May 3, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants