Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-1.27] Use a versioned worker config stack #4480

Merged
merged 1 commit into from
May 23, 2024
Merged

[Backport release-1.27] Use a versioned worker config stack #4480

merged 1 commit into from
May 23, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented May 23, 2024

@twz123
Use a versioned worker config stack
a5ed349 
The worker config ConfigMaps have the Kubernetes version in their names.
This is to ensure a seamless upgrade path when upgrading minor k0s
versions. However, the RBAC resources and the stack name itself didn't
have the version in their names. This means that as soon as a controller
with the new minor k0s version takes over, it removes all previous
worker ConfigMaps from the cluster, effectively defeating the purpose of
the versioned names.

Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
(cherry picked from commit 90e952b)
(cherry picked from commit d8b02f5)
(cherry picked from commit 7336132)
(cherry picked from commit bcd2c31)
@twz123 twz123 added bug Something isn't working area/controlplane labels May 23, 2024
@twz123 twz123 marked this pull request as ready for review May 23, 2024 20:06
@twz123 twz123 requested a review from a team as a code owner May 23, 2024 20:06
@twz123 twz123 requested review from ncopa and makhov May 23, 2024 20:06
@twz123 twz123 merged commit e210963 into k0sproject:release-1.27 May 23, 2024
70 checks passed
@twz123 twz123 deleted the backport-4464-to-release-1.27 branch May 23, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnummelin jnummelin jnummelin approved these changes

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

Assignees
No one assigned
Labels
area/controlplane bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@twz123 @jnummelin