Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report disk space as percent in addition to iecBytes #4719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented Jul 4, 2024

Fixes: #3644

Description

Fixes # 3644

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@ncopa ncopa requested a review from a team as a code owner July 4, 2024 17:19
@ncopa ncopa requested review from kke and twz123 July 4, 2024 17:19
@twz123
Copy link
Member

twz123 commented Jul 5, 2024

The idea was to have two probes, as they might fail due to different thresholds.

@ncopa
Copy link
Collaborator Author

ncopa commented Jul 5, 2024

What threshold should we have for percent free?

@ncopa
Copy link
Collaborator Author

ncopa commented Jul 9, 2024

Seems like I cannot do this without duplicating the code?

@ncopa ncopa marked this pull request as draft July 9, 2024 15:05
Fixes: k0sproject#3644
Signed-off-by: Natanael Copa <ncopa@mirantis.com>
@ncopa ncopa marked this pull request as ready for review July 11, 2024 13:36
@ncopa ncopa enabled auto-merge July 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sysprobe for relative disk space
2 participants