Add option --single for single node #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be in a single node set up we could also automatically use sqlite storage instead of etcd, to save some local machine resources? |
mikhail-sakhnov
previously approved these changes
Feb 26, 2021
jnummelin
requested changes
Feb 26, 2021
Closed
trawler
suggested changes
Feb 26, 2021
yes, absolutely, but solving that is trickier that it may seem. |
|
also join api can be disabled |
ncopa
changed the title
ncopa
changed the title
ncopa
force-pushed
the
single
branch
2 times, most recently
from
b10e832
to
1d05482
Compare
disables konnectivity, and implies --enable-worker Signed-off-by: Natanael Copa <ncopa@mirantis.com>
The k0sVars is currently a package scoped variable in the cmd package. Use that instead of passing it as an argument. Also use the k0sVars instead of constant.GetConfig, so we only get a single call to GetConfig() from a central place. Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Refactor so we can pass the k0sVars with the default storage type. Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Wait til k0s has terminated before restarting it. This should hopefully fix the hacontrolplan test flakiness. Signed-off-by: Natanael Copa <ncopa@mirantis.com>
jnummelin
previously approved these changes
Mar 23, 2021
jasmingacic
previously approved these changes
Mar 23, 2021
trawler
previously approved these changes
Mar 23, 2021
Signed-off-by: Natanael Copa <ncopa@mirantis.com>
ncopa
dismissed stale reviews from trawler, jasmingacic, and jnummelin
via
503294a
trawler
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disables konnectivity, and implies --enable-worker
Signed-off-by: Natanael Copa ncopa@mirantis.com
name: Pull Request
about: Create a Pull Request
title: ''
labels: ''
assignees: ''
Issue
Fixes #720