-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k0s reset: don't use crictl as a dependency #772
k0s reset: don't use crictl as a dependency #772
Conversation
1c56eeb
to
a9fde7b
Compare
@jewertow can you fix the build so we can proceed with the review |
@jasmingacic it seems to be a random failure. Are you able to rerun failed CI plan or do I have to trigger CI by empty commits? |
@jewertow I re-ran it and it failed again. No need to push any more commits. Can you run the same tests locally? |
This test fails when I run it locally due to:
|
#788 fixed flakiness of the tests. Could you rebase your PR so this gets cleared up |
89c547e
to
0e3785d
Compare
@jasmingacic I rebased, but it failed once again. Could you rerun this step? As you saw before, it was working after a retry. |
Ok it is passing now you have to fix the conflicting file :) |
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is looking good. Once the conflict is resolved I will have it approved
0e3785d
to
f033184
Compare
@jasmingacic I rebased PR and fixed conflicts. All checks have passed. |
@trawler can you take a look too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍
Signed-off-by: Jacek Ewertowski jacek.ewertowski1@gmail.com
Issue
Fixes #743
What this PR Includes
crictl
commands.crictl
.How to test this change
All containers should be stopped and removed successfully.