Bump golang to 1.16 for etcd

[gliptak]

---

name: Pull Request
about: Create a Pull Request
title: ''
labels: ''
assignees: ''

---

Issue
Fixes #{ issue number }

What this PR Includes
Bump golang to 1.15 for etcd

[jasmingacic]

@gliptak can you fix CI error before we proceed with review

[gliptak]

@jasmingacic thank you for reviewing

https://github.com/k0sproject/k0s/pull/795/checks?check_run_id=2144826000#step:7:12809 shows

go: inconsistent vendoring in /etcd

It looks that https://github.com/k0sproject/k0s/blob/main/embedded-bins/etcd/Dockerfile#L7 is failing to build with 1.15.

https://travis-ci.com/github/etcd-io/etcd is successful

[jasmingacic]

Funny locally it works just fine. I will trigger the tests again

[jasmingacic]

We will keep this PR open until etcd 3.5.0 is released. We need more time to investigated whether this change will introduce any issues.

[jasmingacic]

So etcd v3.5 will be released sometimes in June

[mikhail-sakhnov]

Since PR was approved already, I converted it to draft to avoid merging by accident

[ncopa]

I think we can merge this. Upstream uses golang 1.12, we currently golang 1.13. The tests passes. golang 1.15 generates better code. We can always revert it if it turns out that it breaks things (but I see no reason why it should).

So I see no reason to hold this back.

[gliptak]

https://github.com/etcd-io/etcd/blob/master/.travis.yml#L9

[gliptak]

etcd 3.5 targets Go 1.16+

[jasmingacic]

I've change the PR from draft to ready for review.
I would suggest that we change dockerfile golang version to 1.16 and maybe remove -mod=mod

[jasmingacic]

@ncopa can you take a look too?

[ncopa]

👍