Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install commands to also pass any args to service units #798

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

jnummelin
Copy link
Collaborator

Signed-off-by: Jussi Nummelin jnummelin@mirantis.com

Issue
Currently k0s install worker <token> drops the token from the service unit.

What this PR Includes
This PR adds all args to the service unit file:

/ # ./k0s install worker "foobar"
INFO[2021-03-19 11:33:52] Installing k0s service                       
/ # cat /etc/init.d/k0sworker 
#!/sbin/openrc-run
supervisor=supervise-daemon
name="k0s worker"
description="k0s - Zero Friction Kubernetes"
command=/k0s
command_args="worker foobar "
name=$(basename $(readlink -f $command))
supervise_daemon_args="--stdout /var/log/${name}.log --stderr /var/log/${name}.err"
depend() { 
        need net 
        use dns 
        after firewall
}

Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
@jnummelin jnummelin added bug Something isn't working area/cli labels Mar 19, 2021
@jnummelin jnummelin requested a review from a team as a code owner March 19, 2021 14:09
@ncopa ncopa merged commit b57ea11 into k0sproject:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants