Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pod logs check in smokes by always getting a fresh list of pods to find ready pods from #912

Merged
merged 1 commit into from May 20, 2021

Conversation

jnummelin
Copy link
Collaborator

Signed-off-by: Jussi Nummelin jnummelin@mirantis.com

Issue
The pod logs check in smokes is bit flaky as the test in correctly uses "stale" list of pods to find running pods from.

What this PR Includes
This makes the pod logs check to always get fresh list of pods so we do not try to re-use stale information.

…o find ready pods from

Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
@jnummelin jnummelin requested a review from a team as a code owner May 20, 2021 08:25
@jnummelin jnummelin requested review from trawler, s0j, ncopa and mikhail-sakhnov and removed request for trawler and s0j May 20, 2021 08:25
@jnummelin jnummelin added backport/release-1.21 bug Something isn't working labels May 20, 2021
Copy link
Collaborator

@ncopa ncopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncopa ncopa merged commit 9f3ae39 into k0sproject:main May 20, 2021
@jnummelin jnummelin deleted the fix-pod-logs-in-smokes branch May 20, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/release-1.21 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants