Configurable mode for kube proxy #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
- The Applier discovery internals were not properly initialized if stack delete happens before apply - The "unit" test was not testing the stack delete path at all - When trying to ignore NotFound and Gone cases in resource deletion, code incorrectly always returned an error --> only one resource per stack was deleted 🤦 - Discovering pruneable resource incorrectly collected the api group/version/kind info as empty strings. Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jnummelin
added
bug
…in stack apply Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
…bject Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
|
Marking as draft as this needs some finetuning... Now that the API discovery is actually properly working, it turns out that finding prunable resources takes quite a bit of time and resources: This is the reason why smokes are red, we're hitting timeouts. 😢 Need to figure out some way(s) to speed things up |
Some general refactorings for stack to simplify and add debuggability. Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
…n creadnetials so we know we have full access to all namespaces anyway. Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
…When we bootup k0s, it needs to sync / apply LOT of manifests and resource in the API and thus will make lot of requests. Thus many of the calls ended up being throttled thus slowing up the speed in which we get everything up-and-running. Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
ncopa
reviewed
May 28, 2021
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
ncopa
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently kube-proxy mode is not really configurable. There are cases when we want to make the proxy mode something else than the default
iptables, e.g.:Partial (the kube-proxy part) fix for #427 as this now add possibility to disable kube-proxy completely.
What this PR Includes
This PR makes kube proxy mode configurable and possible to disable too.
This also includes quite a few fixes for the stack delete logic as that was pretty badly broken in some cases.