Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metrics test to its own test #943

Merged
merged 2 commits into from
May 31, 2021
Merged

Conversation

ncopa
Copy link
Collaborator

@ncopa ncopa commented May 28, 2021

What this PR Includes
Move metrics test to its own test so the basic test runs faster

@ncopa ncopa requested a review from a team as a code owner May 28, 2021 13:11
jasmingacic
jasmingacic previously approved these changes May 28, 2021
jnummelin
jnummelin previously approved these changes May 28, 2021
Copy link
Collaborator

@jnummelin jnummelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the commented code

LGTM otherwise

inttest/metrics/metrics_test.go Show resolved Hide resolved
ncopa added 2 commits May 31, 2021 10:40
waiting for metrics server to come up takes a while, so move that test
to its own to reduce time of running basic test

Signed-off-by: Natanael Copa <ncopa@mirantis.com>
Signed-off-by: Natanael Copa <ncopa@mirantis.com>
@ncopa ncopa merged commit 48c59ce into k0sproject:main May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants