Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kube version string to use '+' as suffix #949

Merged
merged 1 commit into from
Jun 6, 2021

Conversation

jnummelin
Copy link
Collaborator

Signed-off-by: Jussi Nummelin jnummelin@mirantis.com

Issue
In semver - signifies a pre-release, thus the reported Kubernetes server version is slightly wrong:

kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:28:09Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"20+", GitVersion:"v1.20.5-k0s1", GitCommit:"6b1d87acf3c8253c123756b9e61dac642678305f", GitTreeState:"clean", BuildDate:"2021-04-08T09:00:44Z", GoVersion:"go1.15.11", Compiler:"gc", Platform:"linux/amd64"}

What this PR Includes
This PR changes the k0s build kube version to use a "static" +k0s suffix as that's more correct from semver point of view.

…mver '-' signifies pre-release

Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
@jnummelin jnummelin requested a review from a team as a code owner June 1, 2021 12:51
@jnummelin jnummelin requested review from ncopa and s0j June 1, 2021 12:51
@jnummelin jnummelin merged commit 4eff1cf into main Jun 6, 2021
@jnummelin jnummelin deleted the fix-kube-build-version branch June 6, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants