k0sctl does not set node-ip to private address when using controller+worker

[logan2211]

When using a configuration like

  - ssh:
      address: xxx.xxx.xxx.xxx
      user: admin
    role: controller+worker

The private interface and private address are detected when discovering facts from the node, but the node-ip is not set for the worker because #181 specifically excludes nodes marked as controllers from its config:

k0sctl/config/cluster/host.go

Lines 197 to 205 in 0063740

	if !h.IsController() && h.PrivateAddress != "" {
	// set worker's private address to --node-ip in --extra-kubelet-args
	var extra Flags
	if old := flags.GetValue("--kubelet-extra-args"); old != "" {
	extra = Flags{unQE(old)}
	}
	extra.AddUnlessExist(fmt.Sprintf("--node-ip=%s", h.PrivateAddress))
	flags.AddOrReplace(fmt.Sprintf("--kubelet-extra-args=%s", strconv.Quote(extra.Join())))
	}

I think this exclusion needs to be adjusted so it can accommodate dual-role hosts that are marked as both controllers and workers.

[kke]

I believe #205 should fix this.

[logan2211]

Built k0sctl with the fix and confirmed it works. I guess it will need some further adjustment once controller+worker is deprecated at some point in the future as discussed in #203, but it works well now in the interim! Thank you!

[kke]

Fixed in v0.10.1