Use worker's private address as kubelet's node-ip #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmingacic
approved these changes
Aug 5, 2021
|
erdii
pushed a commit
to erdii/k0sctl
that referenced
this pull request
Aug 10, 2021
* Use worker's private address as kubelet's node-ip * Resolve private addresses for all hosts * Wrong argument * Adapt tests * Actually adapt tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
As mentioned in the issue, k0sctl should automatically set the
--extra-kubelet-args="--node-ip x.x.x.x"for workers having a private address.The private address is now auto-discovered during Gather Facts for workers too.