Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list of os dependencies and commands that are being installed on linu… #129

Closed
wants to merge 1 commit into from

Conversation

jasmingacic
Copy link
Contributor

Signed-off-by: jasmingacic jasmin.gacic@gmail.com

docs/dependencies.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kke kke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these are actually shell builtins (bash).

docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
docs/dependencies.md Outdated Show resolved Hide resolved
Signed-off-by: jasmingacic <jasmin.gacic@gmail.com>
@jasmingacic
Copy link
Contributor Author

@kke I somewhat changed the doc. Also @jnummelin suggested we moved this to the main README instead of having it in a separate file. What do you think it is the best to put it?

@jasmingacic jasmingacic requested a review from kke May 20, 2021 12:37
@kke
Copy link
Contributor

kke commented May 20, 2021

It's better now, but I'm not sure if listing all the commands is really necessary. Are there really systems without mv, rm, chmod, etc? It's going to be hard to keep this list up to date.

The package managers pretty much come with the distributions, I don't know if anyone would have an ubuntu without apt or rhel without yum and expect anything to work on it.

I think the essential ones are these:

  • iptables - (instaling iptables could be kind of a big deal to some people? maybe we could somehow get rid of the requirement, we're not configuring anything using it anyway, just used to figure out some ip address stuff)
  • sudo - (installed on alpine, installing sudo sounds like a relevant system security change)

@jasmingacic
Copy link
Contributor Author

@jnummelin can you chime in

@jnummelin
Copy link
Contributor

Are there really systems without mv, rm, chmod, etc? It's going to be hard to keep this list up to date.

This is a good point. Maybe we should limit this into what we try to setup.

iptables - (instaling iptables could be kind of a big deal to some people? maybe we could somehow get rid of the requirement, we're not configuring anything using it anyway, just used to figure out some ip address stuff)

iptables is required by kubernetes components. We've got some ideas how to get rid of it in k0s side, but no real actions yet on it.

installing sudo sounds like a relevant system security change

Yeah, maybe not a good idea to do that sort of thing on-the-fly in general. Maybe instead we could try to detect (and adapt) if the user is root or not, if not root then check whether sudo is available or not and bail out if not.

@ncopa
Copy link
Contributor

ncopa commented Jun 3, 2021

  • sudo - (installed on alpine, installing sudo sounds like a relevant system security change)

FWIW, I personally use doas instead of sudo on basically all my alpine boxes.

We could have an h.SudoExecf wrapper to be used instead of h.Execf("sudo ...") in rig. It could append sudo prefix if uid!=0, and maybe fallback to doas in case sudo does not exist.

@kke
Copy link
Contributor

kke commented Jun 7, 2021

Yes that makes sense.

@jnummelin
Copy link
Contributor

We could have an h.SudoExecf wrapper to be used instead of h.Execf("sudo ...") in rig. It could append sudo prefix if uid!=0, and maybe fallback to doas in case sudo does not exist.

sounds like a good idea. although not really part of this PR at all. :)

@jasmingacic could you adjust the PR based on above comments. so drop the shell build-in commands and the ones that are always there (mv, cp, ...) and focus on the bits we try to put in place (iptables, etc..)

@kke
Copy link
Contributor

kke commented Jun 10, 2021

k0sproject/rig#29 is in the works for the sudo business.

@kke kke closed this Sep 7, 2021
@kke kke deleted the docs_deps_and_cmds branch September 7, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants