-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve k0sctl init usefulness by accepting a list of addresses #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
requested review from
a team,
ncopa,
trawler and
jnummelin
and removed request for
a team
April 30, 2021 08:11
Fishing for thoughts at this point, not actual reviews unless you think it's already good as is. |
I like this idea. I think that we don't really need to worry about stdin support if we have the options as sh get-ip-addr-list.sh | xargs k0sctl --user admin --key-path=~/.ssh/id_rsa which would be equivalent to: sh get-ip-addr-list.sh > /tmp/list
k0sctl --user admin --key-path=~/.ssh/id_rsa $(cat /tmp/list) I also prefer the |
kke
changed the title
[RFC] Accept address list and extra args in k0sctl init
Improve k0sctl init usefulness by accepting a list of addresses
May 4, 2021
ncopa
requested changes
May 4, 2021
Co-authored-by: Natanael Copa <ncopa@mirantis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make
k0sctl init
a bit more useful and the output actually to be usable as-is when you provide some bits of data.Addresses can be set via
k0sctl init address1 address2 address3
or via stdin:somecommand | k0sctl init
.The addresses can be:
With the parameter
--controller-count
you can set how many of those hosts are going to be controllers. An alternative would be to use something like--controllers="address1,address2,..." --workers="address3,address4.."
but that would then be difficult if stdin is accepted 馃 .The keypath, default user and cluster name can be set via flags.
Example:
==>