Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sudo -i with sudo -s to fix nil panic on linux #140

Merged
merged 1 commit into from
May 6, 2021

Conversation

kke
Copy link
Contributor

@kke kke commented May 5, 2021

Updates rig to 0.3.19 to get a fix that changes usages of sudo -i to sudo -s.

Apparently, with sudo -i, on some Linux hosts, things like MOTD and other login messages will be included in the stdout of the command.

There is a slight possibility this breaks things for some hosts that do not add /*sbin to PATH during sudo -s.

Fixes #128
Fixes #130

@kke kke added the bug Something isn't working label May 5, 2021
@kke kke merged commit 1d5d571 into main May 6, 2021
@kke kke deleted the fix-panic-in-isys-detect branch May 6, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on installation, ARM64 [signal SIGSEGV: segmentation violation code=0x1 addr=0x38 pc=0x140fdfc]
1 participant