Update the k0s default config used by k0sctl init #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
commented
May 28, 2021
| coredns: | ||
| image: docker.io/coredns/coredns | ||
| version: 1.7.0 | ||
| calico: |
There was a problem hiding this comment.
hmm but calico is not enabled?
There was a problem hiding this comment.
k0s default-config (currently) always dumps the image ref for all system components, regardless if they are being used or not. So merely a beautification issue, although I can see this might create some confusion.
jnummelin
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like this is not a good idea long term.