-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to restore cluster state from backup at apply #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jasmingacic
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
legit
@kke wanna have a look too? :) |
kke
reviewed
Jun 10, 2021
kke
reviewed
Jun 10, 2021
kke
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, minor typo in docs.
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jnummelin
force-pushed
the
restore-in-apply
branch
from
June 10, 2021 11:37
bccf660
to
9c229d7
Compare
Closed
OmegaSquad82
added a commit
to OmegaSquad82/concourse-k0sctl
that referenced
this pull request
Jun 6, 2022
…om/k0sproject/k0sctl/blob/main/README.md#k0sctl-backup--restore and the initial PR's contents indicate that it skips restore when it encounters an already running k0s installation. k0sproject/k0sctl#149
OmegaSquad82
added a commit
to OmegaSquad82/concourse-k0sctl
that referenced
this pull request
Jun 6, 2022
#8) * As stated in the documentation restore's 4 desasters https://github.com/k0sproject/k0sctl/blob/main/README.md#k0sctl-backup--restore and the initial PR's contents indicate that it skips restore when it encounters an already running k0s installation. k0sproject/k0sctl#149 * Use latest variable to obtain the backup archive * Installed an EXIT trap to save k0sctl's logfile * allow reset in case when the pipeline never ran * Remove the simplest of git functions * Serialize Jobs calling k0sctl against each other * Fix logical error where it checked the target... * Exposed K0SCTL_LOG_PATH as it's default log path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jussi Nummelin jnummelin@mirantis.com
TODO