Add ArchLinux support #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdii
force-pushed
the
add-archlinux-support
branch
from
ce271f7
to
92ae1b0
Compare
erdii
force-pushed
the
add-archlinux-support
branch
from
92ae1b0
to
0d0471d
Compare
kke
reviewed
Aug 10, 2021
configurer/linux/archlinux.go
Outdated
| ) | ||
|
|
||
| // ArchlinuxARM provides OS support for ArchlinuxARM systems | ||
| type ArchlinuxARM struct { |
There was a problem hiding this comment.
I think this should be just ArchLinux as it will detect non-arm Arch as well.
kke
reviewed
Aug 10, 2021
config/cluster/host.go
Outdated
| @@ -379,6 +379,22 @@ func (h *Host) NeedIPTables() bool { | |||
| return !h.Configurer.CommandExist(h, "iptables") | |||
| } | |||
|
|
|||
| // NeedInetUtils returns true when the inetutils package is needed on the host to run `hostname`. | |||
| // Placing this check here is kind of meh because this package probably only exists on arch. | |||
There was a problem hiding this comment.
I think the inetutils package exists on most distros but it'spre-installed on almost all of them. Installing it when hostname is missing may actually solve some rare issues for other distros.
Signed-off-by: erdii <me@erdii.engineering>
erdii
force-pushed
the
add-archlinux-support
branch
from
0d0471d
to
172d9fd
Compare
|
Heyo @kke 👋 |
|
You can now update the go.mod to use rig 0.3.23 to get the rig side of things. |
Signed-off-by: erdii <me@erdii.engineering>
|
Done! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support to deploy on archlinux nodes
tested on archlinuxarm (together with #184)
sibling PR: k0sproject/rig#33