Use custom spec.api.port to check controller state #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
approved these changes
Aug 10, 2021
kke
changed the title
|
Looks like something is broken |
kke
reviewed
Aug 10, 2021
phase/install_controllers.go
Outdated
| @@ -79,6 +79,10 @@ func (p *InstallControllers) Run() error { | |||
| } | |||
|
|
|||
| func (p *InstallControllers) waitJoined(h *cluster.Host) error { | |||
| port := p.Config.Spec.K0s.Config.Dig("spec", "api", "port").(int) | |||
There was a problem hiding this comment.
I think this needs something like:
port := 6443
if p, ok := p.Config.Spec.K0s.Config.Dig("spec", "api", "port").(int); ok {
port = p
}There was a problem hiding this comment.
Gives FATA[0015] PANIC: interface conversion: interface {} is nil, not int when spec.api.port not set otherwise.
There was a problem hiding this comment.
Oh my bad! You are 💯% spot on.
There was a problem hiding this comment.
is this fixed in the commits leading to 83dc9b3? if so, this is also failing with that error (which I don't known if its because this particular line that I'm commenting on):
# k0sctl kubeconfig --config /vagrant/shared/k0sctl.yaml
FATA PANIC: interface conversion: interface {} is nil, not int
kke
reviewed
Aug 10, 2021
phase/upgrade_controllers.go
Outdated
| @@ -63,7 +63,11 @@ func (p *UpgradeControllers) Run() error { | |||
| if err := h.WaitK0sServiceRunning(); err != nil { | |||
| return err | |||
| } | |||
| if err := h.WaitKubeAPIReady(); err != nil { | |||
| port := p.Config.Spec.K0s.Config.Dig("spec", "api", "port").(int) | |||
There was a problem hiding this comment.
same as in install_controllers.go
Signed-off-by: erdii <me@erdii.engineering>
erdii
force-pushed
the
allow-alternative-apiserver-port
branch
from
dac48ad
to
105df2e
Compare
for proper handling of nil values Signed-off-by: erdii <me@erdii.engineering>
erdii
force-pushed
the
allow-alternative-apiserver-port
branch
from
105df2e
to
ee73a12
Compare
kke
approved these changes
Aug 11, 2021
rgl
added a commit
to rgl/k0sctl
that referenced
this pull request
Aug 29, 2021
This reverts commit f6074e9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: erdii me@erdii.engineering