Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible sudo/doas/elevated access usage #192

Merged
merged 12 commits into from
Aug 23, 2021
Merged

More flexible sudo/doas/elevated access usage #192

merged 12 commits into from
Aug 23, 2021

Conversation

kke
Copy link
Contributor

@kke kke commented Aug 18, 2021

Removes the need for sudo binary for hosts with direct root access. Adds support for doas on hosts for users who prefer that.

@kke kke added the enhancement New feature or request label Aug 18, 2021
@kke
Copy link
Contributor Author

kke commented Aug 19, 2021

Weird stuff, apply goes ok, upgrade does not.

@kke
Copy link
Contributor Author

kke commented Aug 19, 2021

I wonder if it's unable to write to the file because the service is running 🤔 How did it work before? Maybe upload to tmpfile anyway so you can minimize the downtime. Upload to tmp + shut down service + swap to new version + restart service.

@kke
Copy link
Contributor Author

kke commented Aug 23, 2021

Odd. Uploading the new binaries stopped working because of: [ssh] 127.0.0.1:9023: upload failed: Process exited with status 1 (tee: /usr/local/bin/k0s: Text file busy\n). I don't know how it could have ever worked.

The k0s binaries need to be uploaded to some tmpfile and used from there until installed into place at some stage of the process.

@kke
Copy link
Contributor Author

kke commented Aug 23, 2021

ValidateFacts finds running k0s version / if an upgrade is necessary.
UploadBinaries uploads the binaries, but it runs before ValidateFacts. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant