Invalidate and remove join tokens after use #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnummelin
reviewed
Sep 9, 2021
phase/install_workers.go
Outdated
| @@ -60,12 +61,24 @@ func (p *InstallWorkers) Run() error { | |||
| return err | |||
| } | |||
|
|
|||
| defer func() { | |||
| if err := p.leader.Exec(p.leader.Configurer.K0sCmdf("invalidate %s", token), exec.RedactString(token)); err != nil { | |||
There was a problem hiding this comment.
shouldn't this be something like:
p.leader.Exec(p.leader.Configurer.K0sCmdf("token invalidate %s", token), exec.RedactString(token))
|
The token can't be invalidated using the token. Would need to know the token id, and that requires guessing. |
|
Actually the ID may be in the beginning of the token if you base64-decode and gunzip it. |
|
And so it is. |
kke
changed the title
jnummelin
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
The generated join tokens will always be invalidated after use