Add single node role #261
Merged
Add single node role #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation for only one single Implement + adapt override test for smoking Update docs Lint Switch role based on installflags Heh Adapt test How is adding new files always so difficult
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #260
The config can now contain exactly one host with
role: single. It will configure the host as a single node cluster as described in k0s documentation.The validator will complain if there is more than one node when there a single role node is present.
The validator will now also complain if there are a) no kind of controllers b) no hosts at all.
The config loading + validation was refactored to happen in a central place instead of replicated in every sub-command.
The "os override" smoke-test was adapted to use a single node setup so that it gets tested.