Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static binary builds for linux #273

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Fix static binary builds for linux #273

merged 2 commits into from
Nov 15, 2021

Conversation

kke
Copy link
Contributor

@kke kke commented Nov 15, 2021

Fixes #272

@kke kke added the bug Something isn't working label Nov 15, 2021
@kke kke changed the title Build static binaries for linux Fix static binary builds for linux Nov 15, 2021
@kke
Copy link
Contributor Author

kke commented Nov 15, 2021

The binary is in the PR artifacts: https://github.com/k0sproject/k0sctl/suites/4354739479/artifacts/114318586

$ ldd k0sctl-linux-x64
	not a dynamic executable

@tipruzs care to confirm?

@tipruzs
Copy link

tipruzs commented Nov 15, 2021

@kke i can confirm, that the binary works on alpine linux now :) many thanks for your blazing fast response and fix!

@kke kke merged commit 929ec35 into main Nov 15, 2021
@kke kke deleted the build-static branch November 15, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release binaries not working on alpine linux
2 participants