Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing backup and tempdir after backup and restore #394

Merged
merged 3 commits into from
May 27, 2022

Conversation

kke
Copy link
Contributor

@kke kke commented May 27, 2022

Fixes #393

The removal was attempted from CWD, not the tempdir.

Also, the tempdir was not removed in neither backup or restore.

@kke kke added the bug Something isn't working label May 27, 2022
@kke
Copy link
Contributor Author

kke commented May 27, 2022

time="2022-05-27T11:14:23Z" level=debug msg="[ssh] 127.0.0.1:9022: cleaning up /tmp/tmp.dpijSWOxAw/k0s_backup.tar.gz/tmp/tmp.dpijSWOxAw"
time="2022-05-27T11:14:23Z" level=debug msg="[ssh] 127.0.0.1:9022: executing `rm -f -- /tmp/tmp.dpijSWOxAw/k0s_backup.tar.gz/tmp/tmp.dpijSWOxAw`"
time="2022-05-27T11:14:23Z" level=info msg="* Running clean-up for phase: Prepare hosts"
time="2022-05-27T11:14:23Z" level=fatal msg="PANIC: runtime error: invalid memory address or nil pointer dereference\n"

@kke kke merged commit 9e46423 into main May 27, 2022
@kke kke deleted the actually-remove-backup branch May 27, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k0sctl not removes temporary file on controller node when backup finished
1 participant