Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the way k0s binary is installed after upload or download #443

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

kke
Copy link
Contributor

@kke kke commented Jan 10, 2023

Signed-off-by: Kimmo Lehto klehto@mirantis.com

Before this PR the k0s binary was installed to the K0sBinaryPath in three different ways depending on:

  • If the file was uploaded from local k0s binary cache to the host
  • If the file was downloaded directly to the host from the k0s repository
  • If performing an upgrade to a running k0s instance (and also this would branch depending on the two ways to get the binary to the host above)

With this PR, the final binary installation is done using the same function.

This may help with the selinux issue in #440 or at least provides a single place where the selinux permission granting can be done.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke added enhancement New feature or request chore Housekeeping / typo / code quality improvements labels Jan 10, 2023
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke merged commit f713d9b into main Jan 10, 2023
@kke kke deleted the unify-k0s-bin-install branch January 10, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Housekeeping / typo / code quality improvements enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant