Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't count empty private addresses during validation #485

Merged
merged 1 commit into from Jun 6, 2023
Merged

Don't count empty private addresses during validation #485

merged 1 commit into from Jun 6, 2023

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Jun 6, 2023

This would fail as soon as there are more than one hosts without a private address.

Fixes:

@twz123
Don't count empty private addresses during validation
7959d6e 
This would fail as soon as there are more than one hosts without a
private address.

Fixes: 0280b8b ("Validate host private address uniqueness")
Signed-off-by: Tom Wieczorek <twieczorek@mirantis.com>
@twz123 twz123 linked an issue Jun 6, 2023 that may be closed by this pull request
private address is not unique (regression between 0.15.0 and 0.15.1) #484
Closed
@twz123 twz123 merged commit 5300b1c into k0sproject:main Jun 6, 2023
21 checks passed
@twz123 twz123 deleted the fix-priv-addr-validation branch June 6, 2023 12:27
@ricardomaraschini
Copy link
Contributor

This is amazing, I was writing an issue for this!

@QJoly QJoly mentioned this pull request Jun 9, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke kke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

private address is not unique (regression between 0.15.0 and 0.15.1)
3 participants
@twz123 @ricardomaraschini @kke