Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordon workers before upgrade #595

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Cordon workers before upgrade #595

merged 2 commits into from
Nov 13, 2023

Conversation

kke
Copy link
Contributor

@kke kke commented Nov 9, 2023

Fixes #541

All workers in the current batch to be upgraded are cordoned before being drained to avoid evacuating workloads to hosts that are just about to be drained.

The workerpool dependency is dropped by using the already implemented BatchedParallelEach.

@kke kke added the enhancement New feature or request label Nov 9, 2023
@kke kke force-pushed the cordon-workers-before-upgrade branch from 2089ed1 to 1e90e9e Compare November 9, 2023 07:12
@kke kke marked this pull request as ready for review November 9, 2023 08:32
jnummelin
jnummelin previously approved these changes Nov 9, 2023
Comment on lines 120 to 132
if !p.NoDrain {
return nil
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the condition be inverse? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn double negatives.

Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke force-pushed the cordon-workers-before-upgrade branch from b68eff2 to 3f988ef Compare November 13, 2023 08:09
@kke kke merged commit ebf9aba into main Nov 13, 2023
31 checks passed
@kke kke deleted the cordon-workers-before-upgrade branch November 13, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade workers optimization: cordon current batch before drain
3 participants