Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip GatherK0sFacts for hosts without pre-existing k0s #606

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

kke
Copy link
Contributor

@kke kke commented Dec 13, 2023

GatherK0sFacts tries multiple k0s commands even after the first k0s version command returns an error.

This PR makes the phase only run on hosts with k0s in PATH.

@kke kke added the chore Housekeeping / typo / code quality improvements label Dec 13, 2023
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
@kke kke force-pushed the give-up-on-gather-k0s-facts branch from befda40 to a1f5e49 Compare December 13, 2023 09:07
@kke kke merged commit 9e799de into main Jan 4, 2024
30 checks passed
@kke kke deleted the give-up-on-gather-k0s-facts branch January 4, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Housekeeping / typo / code quality improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant