-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade with migration #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
reviewed
Feb 19, 2021
kke
reviewed
Feb 19, 2021
kke
reviewed
Feb 19, 2021
jnummelin
force-pushed
the
upgrade-with-migration
branch
from
February 22, 2021 10:45
8733ae7
to
5b1e88a
Compare
jnummelin
force-pushed
the
upgrade-with-migration
branch
2 times, most recently
from
February 23, 2021 14:53
eb088ef
to
5982c6b
Compare
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jnummelin
force-pushed
the
upgrade-with-migration
branch
from
February 24, 2021 09:40
5982c6b
to
2116ac4
Compare
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
jnummelin
force-pushed
the
upgrade-with-migration
branch
from
February 24, 2021 09:42
2116ac4
to
a8fa94e
Compare
kke
reviewed
Feb 24, 2021
kke
reviewed
Feb 24, 2021
kke
reviewed
Feb 24, 2021
kke
reviewed
Feb 24, 2021
kke
reviewed
Feb 24, 2021
Co-authored-by: Kimmo Lehto <kimmo.lehto@gmail.com>
Co-authored-by: Kimmo Lehto <kimmo.lehto@gmail.com>
kke
reviewed
Feb 24, 2021
kke
reviewed
Feb 24, 2021
kke
reviewed
Feb 24, 2021
… is happening Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
Co-authored-by: Kimmo Lehto <kimmo.lehto@gmail.com>
Signed-off-by: Jussi Nummelin <jnummelin@mirantis.com>
…tead of individual installs Co-authored-by: Kimmo Lehto <kimmo.lehto@gmail.com>
kke
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LVGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains now also #90
Includes now a smoke test for the 0.10 -> 0.11 upgrade. Once there's 0.12 (or whatever comes after 0.11 final) k0s available we can update the upgrade version, change the min required version and drop the migration stuff.