has_tag for ALB #472
Merged
has_tag for ALB #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it looks like the reason the build is failing is that the doc isn't generating correctly. I've tried adding |
|
I ran the |
k1LoW
reviewed
May 31, 2019
doc/_resource_types/alb.md
Outdated
| @@ -37,3 +37,11 @@ describe alb('my-alb') do | |||
| it { should belong_to_vpc('my-vpc') } | |||
| end | |||
| ``` | |||
|
|
|||
| ### have_tag | |||
There was a problem hiding this comment.
Could you remove this segment ? (
Duplicate in https://github.com/k1LoW/awspec/pull/472/files#diff-f78ddd4a16af4e4b3cb621d9d3360879R147 and https://github.com/k1LoW/awspec/pull/472/files#diff-f78ddd4a16af4e4b3cb621d9d3360879R155 )
|
@k1LoW Have you had a chance to review this? |
|
@garettmd Thank you !!! ( sorry for late reply 🙏 ) |
|
Released as v1.18.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work yet, but this is what I have so far