Fix pkgnames

analyzer/decisions/pkgnames/pkgnames.go

@@ -3,6 +3,7 @@ package pkgnames
 import (
 	"fmt"
 	"go/ast"
+	"slices"
 	"strings"
 
 	"github.com/gostaticanalysis/comment/passes/commentmap"
@@ -16,9 +17,18 @@ const (
 	name = "pkgnames"
 	doc  = "Analyzer based on https://google.github.io/styleguide/go/decisions#package-names"
 	msg  = "Go package names should be short and contain only lowercase letters. A package name composed of multiple words should be left unbroken in all lowercase. (ref: https://google.github.io/styleguide/go/decisions#package-names)"
+	msg2 = "Avoid uninformative package names like util, utility, common, helper, and so on. (ref: https://google.github.io/styleguide/go/decisions#package-names)"
 )
 
-var disable bool
+var (
+	disable        bool
+	uninformatives = []string{
+		"util",
+		"utility",
+		"common",
+		"helper",
+	}
+)
 
 // Analyzer based on https://google.github.io/styleguide/go/decisions#package-names
 var Analyzer = &analysis.Analyzer{
@@ -57,8 +67,16 @@ func run(pass *analysis.Pass) (any, error) {
 			pkg = true
 			return
 		case *ast.Ident:
-			if pkg && strings.Contains(strings.TrimSuffix(n.Name, "_test"), "_") {
-				r.Append(n.Pos(), fmt.Sprintf("%s: %s", msg, n.Name))
+			if pkg {
+				if strings.Contains(strings.TrimSuffix(n.Name, "_test"), "_") {
+					r.Append(n.Pos(), fmt.Sprintf("%s: %s", msg, n.Name))
+				}
+				if strings.ToLower(n.Name) != n.Name {
+					r.Append(n.Pos(), fmt.Sprintf("%s: %s", msg, n.Name))
+				}
+				if slices.Contains(uninformatives, strings.ToLower(n.Name)) {
+					r.Append(n.Pos(), fmt.Sprintf("%s: %s", msg2, n.Name))
+				}
 			}
 		}
 		pkg = false

analyzer/decisions/pkgnames/pkgnames_test.go

@@ -10,5 +10,5 @@ import (
 // TestAnalyzer is a test for Analyzer.
 func TestAnalyzer(t *testing.T) {
 	testdata := testutil.WithModules(t, analysistest.TestData(), nil)
-	analysistest.Run(t, testdata, Analyzer, "a", "b_bar", "c_car")
+	analysistest.Run(t, testdata, Analyzer, "a", "b_bar", "c_car", "util")
 }

analyzer/decisions/pkgnames/testdata/src/util/util.go

@@ -0,0 +1,3 @@
+package util // want "package"
+
+func f() {}