Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support string expr #71

Merged
merged 2 commits into from
Jul 3, 2022
Merged

Fix support string expr #71

merged 2 commits into from
Jul 3, 2022

Conversation

k2tzumi
Copy link
Collaborator

@k2tzumi k2tzumi commented Jul 2, 2022

Problem

The value to be expanded into an expression is determined to be a number, and single quotes are added to the path and GET parameters.

  • Example

    vars:
  year: 2022
steps:
  -
    req:
      /api/path?year={{ vars.year }}:
        get:

  • Execution logs

    -----START HTTP REQUEST-----
GET /api/path?year=%272022%27 HTTP/1.1

Proposal for revision

If the expanded content after executing string() is not only that expression, it seems better not to stringify it.

Related PR

#21

@k1LoW
Copy link
Owner

k1LoW commented Jul 3, 2022

@k2tzumi You're absolutely right! Thank you!

@k1LoW k1LoW merged commit b78395b into k1LoW:main Jul 3, 2022
@k1LoW k1LoW added the bug Something isn't working label Jul 3, 2022
@k1LoW
Copy link
Owner

k1LoW commented Jul 3, 2022

Released as v0.22.3.

@k1LoW k1LoW mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k2tzumi @k1LoW