Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panics caused by ResponseContentTypeNotFound in the case of a response with a range status code. #914

Merged
merged 3 commits into from
May 6, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented May 6, 2024

Fix #912

@k1LoW k1LoW added the bug Something isn't working label May 6, 2024
@k1LoW k1LoW self-assigned this May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

BenchmarkManyRunbooks-4

main (-) #914 (68f18ef) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 4,055,908,724 ns/op 4,025,410,227 ns/op -30,498,497 ns/op
Bytes allocated per iteration 1,792,641,648 B/op 1,792,765,664 B/op 124,016 B/op
Allocs per iteration 21,418,292 allocs/op 21,417,752 allocs/op -540 allocs/op
Metadata
main (-) #914 (68f18ef)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #914 (68f18ef) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,146,098,510 ns/op 5,077,026,407 ns/op -69,072,103 ns/op
Bytes allocated per iteration 2,947,253,288 B/op 2,946,806,392 B/op -446,896 B/op
Allocs per iteration 29,315,366 allocs/op 29,307,951 allocs/op -7,415 allocs/op
Metadata
main (-) #914 (68f18ef)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #914 (68f18ef) +/-
Number of iterations 16 16 0
Nanoseconds per iteration 67,409,669 ns/op 67,234,138 ns/op -175,531 ns/op
Bytes allocated per iteration 60,331,597 B/op 60,318,574 B/op -13,023 B/op
Allocs per iteration 205,896 allocs/op 205,890 allocs/op -6 allocs/op
Metadata
main (-) #914 (68f18ef)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

github-actions bot commented May 6, 2024

Code Metrics Report

main (09a6f52) #914 (68f18ef) +/-
Coverage 65.6% 65.6% 0.0%
Code to Test Ratio 1:0.5 1:0.4 -0.1
Details
  |                    | main (09a6f52) | #914 (68f18ef) |  +/-  |
  |--------------------|----------------|----------------|-------|
  | Coverage           |          65.6% |          65.6% |  0.0% |
  |   Files            |             71 |             71 |     0 |
  |   Lines            |           7702 |           7702 |     0 |
  |   Covered          |           5055 |           5055 |     0 |
- | Code to Test Ratio |          1:0.5 |          1:0.4 |  -0.1 |
  |   Code             |          22400 |          26098 | +3698 |
+ |   Test             |          10483 |          10611 |  +128 |

Code coverage of files in pull request scope (80.8% → 80.8%)

Files Coverage +/-
coverage.go 79.5% 0.0%
http_validator.go 81.5% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit b60fcab into main May 6, 2024
8 checks passed
@k1LoW k1LoW deleted the fix-panic branch May 6, 2024 03:52
@github-actions github-actions bot mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic occurs while validating OpenAPI response
2 participants