Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove steps[*].run steps.<key>.run from store #933

Merged
merged 1 commit into from
May 22, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented May 22, 2024

Use steps[*].outcome steps.<key>.outcome instead.

Use `steps[*].outcome` `steps.<key>.outcome` instead.
@k1LoW k1LoW self-assigned this May 22, 2024
Copy link
Contributor

BenchmarkManyRunbooks-4

main (-) #933 (986a857) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 3,799,241,199 ns/op 3,920,281,910 ns/op 121,040,711 ns/op
Bytes allocated per iteration 1,792,423,368 B/op 1,793,107,648 B/op 684,280 B/op
Allocs per iteration 21,406,018 allocs/op 21,406,537 allocs/op 519 allocs/op
Metadata
main (-) #933 (986a857)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkOpenAPI3-4

main (-) #933 (986a857) +/-
Number of iterations 1 1 0
Nanoseconds per iteration 5,264,260,017 ns/op 5,115,478,291 ns/op -148,781,726 ns/op
Bytes allocated per iteration 2,952,437,808 B/op 2,952,131,416 B/op -306,392 B/op
Allocs per iteration 29,383,490 allocs/op 29,380,769 allocs/op -2,721 allocs/op
Metadata
main (-) #933 (986a857)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

BenchmarkSingleRunbook-4

main (-) #933 (986a857) +/-
Number of iterations 15 18 3
Nanoseconds per iteration 68,600,522 ns/op 66,192,439 ns/op -2,408,083 ns/op
Bytes allocated per iteration 60,325,953 B/op 60,277,899 B/op -48,054 B/op
Allocs per iteration 205,781 allocs/op 205,773 allocs/op -8 allocs/op
Metadata
main (-) #933 (986a857)
goos linux linux
goarch amd64 amd64
pkg github.com/k1LoW/runn github.com/k1LoW/runn
cpu AMD EPYC 7763 64-Core Processor AMD EPYC 7763 64-Core Processor

Reported by octocov

Copy link
Contributor

Code Metrics Report

main (125b455) #933 (986a857) +/-
Coverage 64.1% 64.1% +0.0%
Code to Test Ratio 1:0.5 1:0.5 -0.0
Test Execution Time 5m41s 6m5s +24s
Details
  |                     | main (125b455) | #933 (986a857) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          64.1% |          64.1% | +0.0% |
  |   Files             |             75 |             75 |     0 |
  |   Lines             |           8190 |           8188 |    -2 |
- |   Covered           |           5252 |           5251 |    -1 |
- | Code to Test Ratio  |          1:0.5 |          1:0.5 |  -0.0 |
  |   Code              |          23565 |          23562 |    -3 |
- |   Test              |          11198 |          11191 |    -7 |
- | Test Execution Time |          5m41s |           6m5s |  +24s |

Code coverage of files in pull request scope (79.5% → 79.5%)

Files Coverage +/-
operator.go 80.0% +0.1%
store.go 76.6% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit 72dec4c into main May 22, 2024
8 checks passed
@k1LoW k1LoW deleted the remove-step-run-from-store branch May 22, 2024 04:17
@github-actions github-actions bot mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant