fix bug where S3 client would not get instantiated with offline options #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems as though the
s3Options
object was intended for use in instantiatingprovider.sdk.S3
, but was never actually used for this...This affected the usage of
serverless-s3-sync
in offline mode, because the endpoint would not be respected and the sync process would attempt to talk to AWS. When using credentials configured for S3RVER (serverless-s3-local), runningsls offline start
results this error:Isolating the network results in this error:
...confirming my suspicion.
In addition, the
bucketNameKey
logic will not work correctly under these circumstances, because it attempts to do the same thing to find thebucketName
, so I added something to the README about that; and fixed the parameter name for the AWS credentials profile.